Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set eurostat_url as an option when package starts #124

Merged
merged 1 commit into from
Aug 28, 2018

Conversation

paulrougieux
Copy link
Contributor

@paulrougieux paulrougieux commented Aug 28, 2018

As discussed in #123

Set the option only if it is not already set, inspired by dplyr:
https://github.com/tidyverse/dplyr/blob/bbcfe99e29fe737d456b0d7adc33d3c445a32d9d/R/zzz.r

@antagomir
Copy link
Member

Some travis checks not successfull. I did not find the explanation yet. https://travis-ci.org/rOpenGov/eurostat/jobs/421445589

@paulrougieux
Copy link
Contributor Author

Related issues could be random error happening with apt get calls:
travis-ci/travis-ci#8507
and
travis-ci/travis-ci#9112
Can you relaunch the travis build?

@paulrougieux
Copy link
Contributor Author

paulrougieux commented Aug 28, 2018

This travis job ran successfully https://travis-ci.org/rOpenGov/eurostat/jobs/421445590
And this one failed https://travis-ci.org/rOpenGov/eurostat/jobs/421445589
The funny thing is that they are both based on the same commit: 7ade7ae

@antagomir
Copy link
Member

Yes I had noticed those points too.. but relaunching the build magically solved the issue. Merging.

@antagomir antagomir merged commit 1200d0c into rOpenGov:master Aug 28, 2018
@antagomir
Copy link
Member

Next time perhaps desirable to make the pull request to the devel branch. I agree that this has not been clearly instructed anywhere.

@antagomir
Copy link
Member

.. and many thanks!

@paulrougieux
Copy link
Contributor Author

OK

Next time perhaps desirable to make the pull request to the devel branch.

Sorry, I didn't know about the devel branch.

I temporarily patched the code for a colleague who uses the package to collect data.
Can you please notify us here when the eurostat package is updated on CRAN?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants