Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better integration with iotables #219

Closed
antaldaniel opened this issue Jun 24, 2021 · 2 comments
Closed

Better integration with iotables #219

antaldaniel opened this issue Jun 24, 2021 · 2 comments
Assignees

Comments

@antaldaniel
Copy link
Contributor

Similarly to 218 I would make a very cheap call and message to downloads of symmetric input-output tables. This affects about 12 products in the entire Eurostat catalgoue, however, I think it is important, because these special products should not be read as a data frame, but as a strictly formed matrix. They are meant to be used in input-output matrix equations. So the downloader with its long-form data frame is useless, and basically the entire point of the iotables R package on rOpenGov to make them useable.

So, I would add a simple check in the downloader function making sure that if these few codes are in the id parameter, the user gets a message the she should rather download this with the special downloader of iotables.

The iotables need not become a dependency of eurostat, therefore no extra weight is given to the package.

@antagomir
Copy link
Member

Yes, really good.

@antaldaniel
Copy link
Contributor Author

Included in PR 220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants