Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better integration with regions #218

Closed
antaldaniel opened this issue Jun 24, 2021 · 2 comments
Closed

Better integration with regions #218

antaldaniel opened this issue Jun 24, 2021 · 2 comments
Assignees

Comments

@antaldaniel
Copy link
Contributor

I would suggest the following simple integration steps

  1. Whenever the user downloads a dataset, and the dataset contains regional geo codes (this can be established with a very quick call) the user gets a message that special care is needed and prompted to review the regional vignette, and/or run validate_nuts_codes.

  2. I would import and put into the eurostat documentation the two crucial functions of regions, validate_nuts_code, and recode_nuts, becuase these are essential to work with the regional datasets. The rest of regions (imputations, etc.) should remain there, as they are non-essential and not trivial tasks.

The extra validation step can be done with a very cheap call, as we only have to check the geo code character lenghs, and rule out excpetions like EU27 and EA19, other than these, if the geo codes are longer than 2 characters, i.e. the country codes, validation is almost always necessary.

Importing two functions will not add a big burden to eurostat, because the joint vignette will anyway suggest the entire regions package, which, in turn, is not very heavy, it often refers back to eurostat itself.

@antagomir , @pitkant , what do you think?

@antagomir
Copy link
Member

Sounds good to me at least. Could you make the PR?

@antaldaniel
Copy link
Contributor Author

Included in PR 220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants