Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict Cython version to <3.0.0 #96

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Restrict Cython version to <3.0.0 #96

merged 4 commits into from
Jul 19, 2023

Conversation

maratsubkhankulov
Copy link
Contributor

@maratsubkhankulov maratsubkhankulov commented Jul 18, 2023 •
edited
Loading

Testing:

This workaround works:

pip install --upgrade Cython==0.29.36
pip install pysptk --no-build-isolation

But would rather not have to rely on --no-build-isolation flag when installing this dependency in my project.

r9y9
r9y9 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Owner

@r9y9 r9y9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@r9y9 r9y9 merged commit 090c578 into r9y9:master Jul 19, 2023
@r9y9 r9y9 mentioned this pull request Jul 20, 2023
Closed
@r9y9
Copy link
Owner

r9y9 commented Jul 20, 2023

This fix is available on the latest release https://github.com/r9y9/pysptk/releases/tag/v0.2.1

@kan-bayashi kan-bayashi mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r9y9 r9y9 r9y9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maratsubkhankulov @r9y9