Windows Specific Filename bugfix #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f arguments)
File "synthesis.py", line 137, in <module>
model, text, p=replace_pronunciation_prob, speaker_id=speaker_id, fast=True)
File "synthesis.py", line 66, in tts
sequence, text_positions=text_positions, speaker_ids=speaker_ids)
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 325, in __call__
result = self.forward(*input, **kwargs)
File "H:\Tensorflow_Study\git\deepvoice3_pytorch\deepvoice3_pytorch\__init__.py", line 79, in forward
text_positions, frame_positions, input_lengths)
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 325, in __call__
result = self.forward(*input, **kwargs)
File "H:\Tensorflow_Study\git\deepvoice3_pytorch\deepvoice3_pytorch\__init__.py", line 116, in forward
text_sequences, lengths=input_lengths, speaker_embed=speaker_embed)
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 325, in __call__
result = self.forward(*input, **kwargs)
File "H:\Tensorflow_Study\git\deepvoice3_pytorch\deepvoice3_pytorch\deepvoice3.py", line 75, in forward
x = self.embed_tokens(text_sequences) <- change this to long!
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 325, in __call__
result = self.forward(*input, **kwargs)
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\sparse.py", line 103, in forward
self.scale_grad_by_freq, self.sparse
File "H:\envs\pytorch\lib\site-packages\torch\nn\_functions\thnn\sparse.py", line 59, in forward
output = torch.index_select(weight, 0, indices.view(-1))
TypeError: torch.index_select received an invalid combination of arguments - got (�[32;1mtorch.cuda.FloatTensor�[0m, �[32;1mint�[0m, �[31;1mtorch.cuda.IntTensor�[0m), but expected (torch.cuda.FloatTensor source, int dim, torch.cuda.LongTensor index)
changed text_sequence to long, as required by torch.index_select.
This reverts commit 5214c24.
In windows, this causes WinError 123
|
Thanks 👍 |
|
btw, it would be nice to cleanup history so that we can review more easily. You can take a look at |
|
Okay I will check it up! (I am not that familiar with git-like system, so I am still learning!) Thank you and have a nice weekend! |
engiecat
added a commit
to engiecat/deepvoice3_pytorch
that referenced
this pull request
Mar 10, 2018
Windows Specific Filename bugfix (r9y9#58) reverse PR
engiecat
added a commit
to engiecat/deepvoice3_pytorch
that referenced
this pull request
May 5, 2018
* Fixed typeerror (torch.index_select received an invalid combination of arguments)
File "synthesis.py", line 137, in <module>
model, text, p=replace_pronunciation_prob, speaker_id=speaker_id, fast=True)
File "synthesis.py", line 66, in tts
sequence, text_positions=text_positions, speaker_ids=speaker_ids)
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 325, in __call__
result = self.forward(*input, **kwargs)
File "H:\Tensorflow_Study\git\deepvoice3_pytorch\deepvoice3_pytorch\__init__.py", line 79, in forward
text_positions, frame_positions, input_lengths)
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 325, in __call__
result = self.forward(*input, **kwargs)
File "H:\Tensorflow_Study\git\deepvoice3_pytorch\deepvoice3_pytorch\__init__.py", line 116, in forward
text_sequences, lengths=input_lengths, speaker_embed=speaker_embed)
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 325, in __call__
result = self.forward(*input, **kwargs)
File "H:\Tensorflow_Study\git\deepvoice3_pytorch\deepvoice3_pytorch\deepvoice3.py", line 75, in forward
x = self.embed_tokens(text_sequences) <- change this to long!
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 325, in __call__
result = self.forward(*input, **kwargs)
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\sparse.py", line 103, in forward
self.scale_grad_by_freq, self.sparse
File "H:\envs\pytorch\lib\site-packages\torch\nn\_functions\thnn\sparse.py", line 59, in forward
output = torch.index_select(weight, 0, indices.view(-1))
TypeError: torch.index_select received an invalid combination of arguments - got (�[32;1mtorch.cuda.FloatTensor�[0m, �[32;1mint�[0m, �[31;1mtorch.cuda.IntTensor�[0m), but expected (torch.cuda.FloatTensor source, int dim, torch.cuda.LongTensor index)
changed text_sequence to long, as required by torch.index_select.
* Fixed Nonetype error in collect_features
* requirements.txt fix
* Memory Leakage bugfix + hparams change
* Pre-PR modifications
* Pre-PR modifications 2
* Pre-PR modifications 3
* Post-PR modification
* remove requirements.txt
* num_workers to 1 in train.py
Windows Filename bugfix
In windows, this causes WinError 123
Windows Specific Filename bugfix (r9y9#58)
* Fixed typeerror (torch.index_select received an invalid combination of arguments)
File "synthesis.py", line 137, in <module>
model, text, p=replace_pronunciation_prob, speaker_id=speaker_id, fast=True)
File "synthesis.py", line 66, in tts
sequence, text_positions=text_positions, speaker_ids=speaker_ids)
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 325, in __call__
result = self.forward(*input, **kwargs)
File "H:\Tensorflow_Study\git\deepvoice3_pytorch\deepvoice3_pytorch\__init__.py", line 79, in forward
text_positions, frame_positions, input_lengths)
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 325, in __call__
result = self.forward(*input, **kwargs)
File "H:\Tensorflow_Study\git\deepvoice3_pytorch\deepvoice3_pytorch\__init__.py", line 116, in forward
text_sequences, lengths=input_lengths, speaker_embed=speaker_embed)
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 325, in __call__
result = self.forward(*input, **kwargs)
File "H:\Tensorflow_Study\git\deepvoice3_pytorch\deepvoice3_pytorch\deepvoice3.py", line 75, in forward
x = self.embed_tokens(text_sequences) <- change this to long!
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\module.py", line 325, in __call__
result = self.forward(*input, **kwargs)
File "H:\envs\pytorch\lib\site-packages\torch\nn\modules\sparse.py", line 103, in forward
self.scale_grad_by_freq, self.sparse
File "H:\envs\pytorch\lib\site-packages\torch\nn\_functions\thnn\sparse.py", line 59, in forward
output = torch.index_select(weight, 0, indices.view(-1))
TypeError: torch.index_select received an invalid combination of arguments - got (�[32;1mtorch.cuda.FloatTensor�[0m, �[32;1mint�[0m, �[31;1mtorch.cuda.IntTensor�[0m), but expected (torch.cuda.FloatTensor source, int dim, torch.cuda.LongTensor index)
changed text_sequence to long, as required by torch.index_select.
* Fixed Nonetype error in collect_features
* requirements.txt fix
* Memory Leakage bugfix + hparams change
* Pre-PR modifications
* Pre-PR modifications 2
* Pre-PR modifications 3
* Post-PR modification
* remove requirements.txt
* num_workers to 1 in train.py
* Windows log filename bugfix
* Revert "Windows log filename bugfix"
This reverts commit 5214c24.
* merge 2
* Windows Filename bugfix
In windows, this causes WinError 123
* Cleanup before PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Sorry for creating PR again, but I just discovered that tensorboard logfile name format is incompatible with Windows because of ":" in the filename.
This can be mitigated by using log-event-path option currently.
Have a nice weekend!