Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required tools to the codespace image #127

Merged
merged 7 commits into from
Dec 8, 2023
Merged

Add required tools to the codespace image #127

merged 7 commits into from
Dec 8, 2023

Conversation

anayden
Copy link
Collaborator

@anayden anayden commented Nov 24, 2023

This adds chafa and just to the dev image.

One can play with it via
Untitled

P.S. Don't forget to shutdown your codespace when you don't need it
P.P.S. Note this also adds chafa to the base image for future usage in R2DT

@anayden anayden requested a review from AntonPetrov November 24, 2023 12:25
@anayden anayden changed the base branch from main to develop November 24, 2023 12:26
Copy link

github-actions bot commented Nov 24, 2023

Docker image tag(s) pushed:

rnacentral/r2dt:pr-127

Labels added to images:

org.opencontainers.image.created=2023-12-07T22:16:18.011Z
org.opencontainers.image.description=Visualise RNA secondary structure in consistent, reproducible and recognisable layouts
org.opencontainers.image.licenses=Apache-2.0
org.opencontainers.image.revision=f20ec09e9a1a286c1d14882f422e637c50021ecc
org.opencontainers.image.source=https://github.com/RNAcentral/R2DT
org.opencontainers.image.title=R2DT
org.opencontainers.image.url=https://github.com/RNAcentral/R2DT
org.opencontainers.image.version=pr-127

@AntonPetrov
Copy link
Member

@anayden I am very sorry for taking so long to review this PR but I tested it and it worked! 🎉👏

During my testing, I created a Codespace based on this branch, ran just run to get an image, then did r2dt.py test TestTemplateFree to get a thumbnail image, then exited the container, and ran chafa to view the thumbnail in console.

In general, this PR lays the groundwork for 2 cool features:

  1. using R2DT in Codespaces (which seems to work well and can be merged now so that one can do further testing and try to use it for actual development). What do you think about adding an Open in Codespaces badge in Readme?
  2. viewing SVGs in console by adding a new flag to r2dt.py. For example, by default it does not show the 2Ds but with --view-results or similar it would show all images from the thumbnail folder.

I am ready to merge this PR, if you think it's ready. Alternatively, we can add more functionality in this branch - up to you!

Thank you again for bravely exploring the new territory and adding exciting new capabilities to R2DT!

@anayden
Copy link
Collaborator Author

anayden commented Dec 7, 2023

Hey, thanks for looking into it. I've added the badge to README.md and I think it's time to merge (if you're okay with the badge placement)

@AntonPetrov AntonPetrov merged commit d75a8b0 into develop Dec 8, 2023
17 checks passed
@AntonPetrov AntonPetrov deleted the codespace branch December 8, 2023 09:41
@AntonPetrov AntonPetrov mentioned this pull request Dec 8, 2023
@AntonPetrov AntonPetrov mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants