Skip to content
Build, test and lint

feat: separate runtimes #136

Sign in to view logs

feat: separate runtimes

feat: separate runtimes #136

GitHub Actions / clippy failed Mar 26, 2024 in 0s

clippy

2 errors, 4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 2
Warning 4
Note 0
Help 0

Versions

  • rustc 1.77.0 (aedd173a2 2024-03-17)
  • cargo 1.77.0 (3fe68eabf 2024-02-29)
  • clippy 0.1.77 (aedd173 2024-03-17)

Annotations

Check failure on line 297 in node/src/command.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type annotations needed 

error[E0283]: type annotations needed
   --> node/src/command.rs:297:21
    |
297 |                     let partials = new_partial(&config)?;
    |                                    ^^^^^^^^^^^ cannot infer type of the type parameter `RuntimeApi` declared on the function `new_partial`
    |
    = note: multiple `impl`s satisfying `_: sp_api::ConstructRuntimeApi<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, polkadot_primitives::BlakeTwo256>, sp_runtime::OpaqueExtrinsic>, sc_service::client::client::Client<sc_client_db::Backend<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, polkadot_primitives::BlakeTwo256>, sp_runtime::OpaqueExtrinsic>>, sc_service::LocalCallExecutor<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, polkadot_primitives::BlakeTwo256>, sp_runtime::OpaqueExtrinsic>, sc_client_db::Backend<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, polkadot_primitives::BlakeTwo256>, sp_runtime::OpaqueExtrinsic>>, sc_executor::NativeElseWasmExecutor<_>>, sp_runtime::generic::Block<sp_runtime::generic::Header<u32, polkadot_primitives::BlakeTwo256>, sp_runtime::OpaqueExtrinsic>, _>>` found in the following crates: `polkadot_service`, `pop_runtime_devnet`, `pop_runtime_testnet`:
            - impl<Block, C> sp_api::ConstructRuntimeApi<Block, C> for polkadot_cli::polkadot_service::RuntimeApi
              where Block: cumulus_primitives_core::BlockT, C: sp_api::CallApiAt<Block>, C: 'static;
            - impl<Block, C> sp_api::ConstructRuntimeApi<Block, C> for pop_runtime_devnet::RuntimeApi
              where Block: cumulus_primitives_core::BlockT, C: sp_api::CallApiAt<Block>, C: 'static;
            - impl<Block, C> sp_api::ConstructRuntimeApi<Block, C> for pop_runtime_testnet::RuntimeApi
              where Block: cumulus_primitives_core::BlockT, C: sp_api::CallApiAt<Block>, C: 'static;
note: required by a bound in `service::new_partial`
   --> node/src/service.rs:102:3
    |
97  | pub fn new_partial<RuntimeApi, Executor>(
    |        ----------- required by a bound in this function
...
102 |         ConstructRuntimeApi<Block, ParachainClient<RuntimeApi, Executor>> + Send + Sync + 'static,
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `new_partial`
help: consider specifying the generic arguments
    |
297 |                     let partials = new_partial::<RuntimeApi, Executor>(&config)?;
    |                                               ++++++++++++++++++++++++

Check failure on line 297 in node/src/command.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type annotations needed 

error[E0284]: type annotations needed
   --> node/src/command.rs:297:21
    |
297 |                     let partials = new_partial(&config)?;
    |                                    ^^^^^^^^^^^ cannot infer type of the type parameter `RuntimeApi` declared on the function `new_partial`
    |
    = note: cannot satisfy `<_ as sp_api::ConstructRuntimeApi<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, polkadot_primitives::BlakeTwo256>, sp_runtime::OpaqueExtrinsic>, sc_service::client::client::Client<sc_client_db::Backend<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, polkadot_primitives::BlakeTwo256>, sp_runtime::OpaqueExtrinsic>>, sc_service::LocalCallExecutor<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, polkadot_primitives::BlakeTwo256>, sp_runtime::OpaqueExtrinsic>, sc_client_db::Backend<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, polkadot_primitives::BlakeTwo256>, sp_runtime::OpaqueExtrinsic>>, sc_executor::NativeElseWasmExecutor<_>>, sp_runtime::generic::Block<sp_runtime::generic::Header<u32, polkadot_primitives::BlakeTwo256>, sp_runtime::OpaqueExtrinsic>, _>>>::RuntimeApi == _`
help: consider specifying the generic arguments
    |
297 |                     let partials = new_partial::<RuntimeApi, Executor>(&config)?;
    |                                               ++++++++++++++++++++++++

Check warning on line 328 in runtime/devnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `cumulus_primitives_core::Location` 

warning: useless conversion to the same type: `cumulus_primitives_core::Location`
   --> runtime/devnet/src/extensions.rs:328:35
    |
328 |                 .deposit_asset(assets.into(), beneficiary.into())
    |                                               ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `beneficiary`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 321 in runtime/devnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `cumulus_primitives_core::Asset` 

warning: useless conversion to the same type: `cumulus_primitives_core::Asset`
   --> runtime/devnet/src/extensions.rs:321:20
    |
321 |                 .buy_execution(assets.clone().into(), Unlimited)
    |                                ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `assets.clone()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 328 in runtime/testnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `cumulus_primitives_core::Location` 

warning: useless conversion to the same type: `cumulus_primitives_core::Location`
   --> runtime/testnet/src/extensions.rs:328:35
    |
328 |                 .deposit_asset(assets.into(), beneficiary.into())
    |                                               ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `beneficiary`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 321 in runtime/testnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `cumulus_primitives_core::Asset` 

warning: useless conversion to the same type: `cumulus_primitives_core::Asset`
   --> runtime/testnet/src/extensions.rs:321:20
    |
321 |                 .buy_execution(assets.clone().into(), Unlimited)
    |                                ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `assets.clone()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default
View more details on GitHub Actions