chore: ink v5.1 #409
Merged
chore: ink v5.1 #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daanvdplas
force-pushed
the
daan/chore-ink_v5.1
branch
from
422a61b to
0419035
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 68.41% 68.41%
=======================================
Files 70 70
Lines 11838 11838
Branches 11838 11838
=======================================
Hits 8099 8099
Misses 3482 3482
Partials 257 257 |
|
Should we use git path to latest main branch then? |
Why? |
To avoid updating the version every time there's a new update. Anyway, this could brings unexpected issues so ignore my comment. |
chungquantin
approved these changes
Dec 19, 2024
AlexD10S
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v5.0 there was an ugly warning from the linter which is fixed in v5.1. Also good to uplift the version.