Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pop-api): further implementation of nfts api #21

Merged
merged 10 commits into from
Mar 7, 2024
Merged

feat(pop-api): further implementation of nfts api #21

merged 10 commits into from
Mar 7, 2024

Conversation

evilrobot-01
Copy link
Collaborator

@evilrobot-01 evilrobot-01 commented Mar 6, 2024 •
edited
Loading

Implements the remaining runtime calls that were listed, along with a few queries.

Notes:

  • Removes the offchain signing calls for now.
  • Have not implemented those which require AccountId to be added to primitives (e.g. custom attribute). It results in a dependency mismatch between the runtime and that required by ink. Need to find a solution for this.
  • Suggest moving pop-api-primitives to pop-primitives in a separate PR

@evilrobot-01 evilrobot-01 marked this pull request as draft March 6, 2024 21:59
@evilrobot-01 evilrobot-01 marked this pull request as ready for review March 7, 2024 22:15
@evilrobot-01 evilrobot-01 requested review from peterwht, al3mart and Daanvdplas and removed request for al3mart and peterwht March 7, 2024 22:15
peterwht
peterwht reviewed Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Left a few nit-picky comments

pop-api/primitives/src/lib.rs Show resolved Hide resolved
pop-api/src/v0/nfts.rs Show resolved Hide resolved
pop-api/src/v0/nfts.rs Show resolved Hide resolved
runtime/src/extensions.rs Show resolved Hide resolved
@peterwht peterwht mentioned this pull request Mar 7, 2024
Closed
peterwht
peterwht approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@peterwht peterwht left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. See issues #27 and #26

al3mart
al3mart approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@al3mart al3mart left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good.

I guess we can address moving those primitives in the same PR that takes ParachainSystem read state logic out of the general read_state() function.

Are we coming back to having modules for the different implementations of the extension ? ;)

@evilrobot-01 evilrobot-01 merged commit a87e19d into main Mar 7, 2024
5 checks passed
@evilrobot-01 evilrobot-01 deleted the frank/feat-nfts branch March 7, 2024 23:21
@Daanvdplas Daanvdplas mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al3mart al3mart al3mart approved these changes

@peterwht peterwht peterwht approved these changes

@Daanvdplas Daanvdplas Awaiting requested review from Daanvdplas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evilrobot-01 @al3mart @peterwht