Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build spec experience #331

Merged
merged 35 commits into from
Dec 5, 2024

docs: deprecation message

3cd8194
Select commit
Loading
Failed to load commit list.
Merged

fix: build spec experience #331

docs: deprecation message
3cd8194
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 1s

74.29% (+1.69%) compared to d1cf48d

View this Pull Request on Codecov

74.29% (+1.69%) compared to d1cf48d

Details

Codecov Report

Attention: Patch coverage is 81.43564% with 150 lines in your changes missing coverage. Please review.

Project coverage is 74.29%. Comparing base (d1cf48d) to head (3cd8194).

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/build/spec.rs 81.49% 52 Missing and 42 partials ⚠️
crates/pop-cli/src/cli.rs 46.34% 22 Missing ⚠️
crates/pop-parachains/src/build.rs 75.86% 4 Missing and 10 partials ⚠️
crates/pop-cli/src/commands/build/mod.rs 66.66% 8 Missing and 4 partials ⚠️
crates/pop-cli/src/commands/build/parachain.rs 66.66% 0 Missing and 4 partials ⚠️
crates/pop-common/src/manifest.rs 95.08% 0 Missing and 3 partials ⚠️
crates/pop-common/src/build.rs 98.18% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   72.59%   74.29%   +1.69%     
==========================================
  Files          56       56              
  Lines       10700    11233     +533     
  Branches    10700    11233     +533     
==========================================
+ Hits         7768     8345     +577     
+ Misses       1844     1746      -98     
- Partials     1088     1142      +54     
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/call/contract.rs 83.40% <100.00%> (+0.05%) ⬆️
crates/pop-cli/src/commands/mod.rs 16.32% <100.00%> (ø)
crates/pop-common/src/build.rs 98.48% <98.18%> (-1.52%) ⬇️
crates/pop-common/src/manifest.rs 93.51% <95.08%> (+0.30%) ⬆️
crates/pop-cli/src/commands/build/parachain.rs 73.49% <66.66%> (+0.32%) ⬆️
crates/pop-cli/src/commands/build/mod.rs 50.00% <66.66%> (-0.71%) ⬇️
crates/pop-parachains/src/build.rs 88.17% <75.86%> (-0.72%) ⬇️
crates/pop-cli/src/cli.rs 65.46% <46.34%> (-1.90%) ⬇️
crates/pop-cli/src/commands/build/spec.rs 73.64% <81.49%> (+73.64%) ⬆️