fix: improve contract experience

[AlexD10S]

• Partially addresses feat: show contract's code_hash upon deployment #290. The code_hash is now displayed when running pop up contract for both upload only (-u) and upload + instantiate scenarios.

For instantiating an already uploaded contract, code_hash is currently not displayed, as retrieving it would require parsing events or querying the value on-chain.

• Additionally, this PR closes feat: show contract-node's node logs for debugging purposes #291

It adds -lerror,runtime::contracts=debug when running substrate-contracts-node to allow debugging messages (the contract has to be build without --release flag).

[codecov]

Codecov Report

Attention: Patch coverage is 27.27273% with 24 lines in your changes missing coverage. Please review.

Project coverage is 70.27%. Comparing base (2af82eb) to head (0ff6eb3).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/pop-cli/src/commands/up/contract.rs	0.00%	22 Missing ⚠️
crates/pop-contracts/src/call.rs	66.66%	0 Missing and 1 partial ⚠️
crates/pop-contracts/src/up.rs	85.71%	0 Missing and 1 partial ⚠️

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   70.33%   70.27%   -0.06%     
==========================================
  Files          53       54       +1     
  Lines        9098     9152      +54     
  Branches     9098     9152      +54     
==========================================
+ Hits         6399     6432      +33     
- Misses       1718     1736      +18     
- Partials      981      984       +3     

Files with missing lines	Coverage Δ
crates/pop-contracts/src/node/mod.rs	64.70% <100.00%> (+0.26%)	⬆️
crates/pop-contracts/src/call.rs	78.62% <66.66%> (ø)
crates/pop-contracts/src/up.rs	77.89% <85.71%> (+0.24%)	⬆️
crates/pop-cli/src/commands/up/contract.rs	23.88% <0.00%> (-1.88%)	⬇️

... and 7 files with indirect coverage changes

[evilrobot-01]

Looks good, various minor improvements and clippy warnings to address and then I'm good to approve.

[brunopgalvao]

Really happy with this PR.

One thing to note, if I re-deploy the same contract, the code hash is not shown:

pop up contract --args true

Code hash is shown for the above command is shown. But then if I re-deploy:

pop up contract --args true --salt 0x3c

Code hash not shown:

┌   Pop CLI : Deploy a smart contract
│
◇  Gas limit estimate: Weight { ref_time: 146361110, proof_size: 16689 }
│
◇  Contract deployed and instantiated:
● The Contract Address is "5HGyVrVkCrKVRBrjXcVFrFzei93YkFBmkA4WHvqw5jk2s8jq"

│
└  🚀 Deployment complete

I guess this is expected as you mentioned here:

For instantiating an already uploaded contract, code_hash is currently not displayed, as retrieving it would require parsing events or querying the value on-chain.

◇  Local node started successfully:
│  portal: https://polkadot.js.org/apps/?rpc=ws://localhost:9944/#/explorer
│  logs: tail -f /var/folders/vl/txnq6gdj22s9rn296z0md27w0000gn/T/.tmpOenKTn

For some reason the logs are empty. Is this the correct log path?

[AlexD10S]

For some reason the logs are empty. Is this the correct log path?

Exactly. If the contract has already been uploaded, retrieving the code_hash is a bit more complex. I left it out for now, but we can handle it later by parsing events or querying on-chain.

As for the logs, they are working.
Keep in mind that the contract must be built without the --release flag to display debug logs (see Ink! Debugging Guide). Also, note that the proposed -lerror,runtime::contracts=debug flag only shows error and debug output. If we need more verbosity, I can switch it to -linfo,runtime::contracts=debug to include all info logs.

[al3mart]

I see the feedback has been included.
I don't have much more to point out rather than a small nit. But definitely not blocking the merge.

The emojis are not colored like the rest of the prompt is :P
Aside from that, I would assume that a user who can instantiate some code, has access to the code and could obtain the hash easily. Though, I agree that being consistent and showing it every time would be the best experience.

[brunopgalvao]

Also, note that the proposed -lerror,runtime::contracts=debug flag only shows error and debug output. If we need more verbosity, I can switch it to -linfo,runtime::contracts=debug to include all info logs.

I think more verbosity would nice.

[AlexD10S]

Also, note that the proposed -lerror,runtime::contracts=debug flag only shows error and debug output. If we need more verbosity, I can switch it to -linfo,runtime::contracts=debug to include all info logs.

I think more verbosity would nice.

Agree. Makes sense to have info

[brunopgalvao]

closes #319