Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: templates errors #329

Merged
merged 2 commits into from
Nov 7, 2024
Merged

fix: templates errors #329

merged 2 commits into from
Nov 7, 2024

Conversation

AlexD10S
Copy link
Collaborator

Closes #323. For the contract_template's cross-contract-calls, it was necessary to rename e2e_tests.rs to match the user-defined input name. Without this adjustment, the e2e tests would fail due to the file not being correctly recognized.

Closes #321 using the PSP34 managed by R0gue: https://github.com/r0gue-io/PSP34

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.38%. Comparing base (2af82eb) to head (f3a6a21).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-contracts/src/new.rs 86.20% 0 Missing and 4 partials ⚠️
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   70.33%   70.38%   +0.04%     
==========================================
  Files          53       53              
  Lines        9098     9123      +25     
  Branches     9098     9123      +25     
==========================================
+ Hits         6399     6421      +22     
  Misses       1718     1718              
- Partials      981      984       +3     
Files with missing lines Coverage Δ
crates/pop-contracts/src/templates.rs 98.24% <100.00%> (ø)
crates/pop-contracts/src/new.rs 82.38% <86.20%> (+0.92%) ⬆️

@brunopgalvao brunopgalvao self-requested a review October 31, 2024 18:45
Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question which might be worth addressing - whether we should wrap the contract name in string delimiters to more precisely target the update.

The rest are purely observational and dont need addressing now.

crates/pop-contracts/src/new.rs Outdated Show resolved Hide resolved
crates/pop-contracts/src/new.rs Outdated Show resolved Hide resolved
crates/pop-contracts/src/new.rs Outdated Show resolved Hide resolved
@AlexD10S AlexD10S requested a review from evilrobot-01 November 5, 2024 22:15
Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexD10S AlexD10S merged commit 0704723 into main Nov 7, 2024
20 checks passed
@AlexD10S AlexD10S deleted the fix/templates branch November 7, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants