-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: templates errors #329
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #329 +/- ##
==========================================
+ Coverage 70.33% 70.38% +0.04%
==========================================
Files 53 53
Lines 9098 9123 +25
Branches 9098 9123 +25
==========================================
+ Hits 6399 6421 +22
Misses 1718 1718
- Partials 981 984 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question which might be worth addressing - whether we should wrap the contract name in string delimiters to more precisely target the update.
The rest are purely observational and dont need addressing now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #323. For the contract_template's
cross-contract-calls
, it was necessary to renamee2e_tests.rs
to match the user-defined input name. Without this adjustment, the e2e tests would fail due to the file not being correctly recognized.Closes #321 using the PSP34 managed by R0gue: https://github.com/r0gue-io/PSP34