-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the "pop up contracts-node" command #185
Conversation
b93c66c
to
efe641b
Compare
Hola @Moliholy! Great to see you here contributing to pop-cli. Looks good to me! We are currently having an open discussion about the best UX for Also after this PR is merged, we can tackle this issue: #35 |
@AlexD10S pleased to be around :-) Yes, I saw that issue before, but I supposed its decision was not taken since it was still open, so I thought the best approach would be, at least for now, to continue with the current project's structure. As for the name itself, I definitely don't have a strong opinion nor I'm particularly good at naming, so if you find a better one feel free to change it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added a little change in a message but the rest looks good to me!
Thanks again for contributing!!
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #185 +/- ##
==========================================
- Coverage 50.41% 50.10% -0.32%
==========================================
Files 32 33 +1
Lines 2858 2876 +18
Branches 2858 2876 +18
==========================================
Hits 1441 1441
- Misses 1194 1212 +18
Partials 223 223
|
Rebased to the latest |
Description
This PR adds the following command that spawns a substrate-contracts-node instance.
It should be executed in a different terminal, and prior to its execution it will check whether the repository is downloaded and build the binary if it isn't.
It's definitely not rocket science, and could be improved, but IMO it's a decent step forward towards a better usage by integrating in the tool a component that was excluded, yet it was used for deploying smart contracts.
Possible improvements
--force
-like command.