Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to stable2409 #52

Merged
merged 2 commits into from
Jan 8, 2025
Merged

chore: upgrade to stable2409 #52

merged 2 commits into from
Jan 8, 2025

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Dec 31, 2024 •
edited
Loading

Uplift base-parachain template to stable2409 - Release Changelog.

Status

  • Builds node & runtime successfully.
  • Parachain node produce blocks with PASEO local.
Screenshot 2024-12-31 at 10 03 20

@chungquantin
Copy link
Collaborator Author

Note for the reviewers: The upgrade in Polkadot SDK's templates change the constant variable names which I don't add to this PR. We discussed in the last PR that we prefer the current Pop templates' constant variable name style.

@chungquantin chungquantin changed the title chore: upgrade polkadot-sdk to stable 2409 chore: upgrade to stable2409 Dec 31, 2024
@chungquantin chungquantin force-pushed the chungquantin/chore-stable2409 branch from b3c817f to defa55f Compare December 31, 2024 04:32
AlexD10S
AlexD10S approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few minor comments, but overall, I approve, looks great, great work!

runtime/src/genesis_config_presets.rs Outdated Show resolved Hide resolved
runtime/src/genesis_config_presets.rs Outdated Show resolved Hide resolved
rust-toolchain.toml Outdated Show resolved Hide resolved
This was referenced Jan 2, 2025
Merged
Merged
al3mart
al3mart reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All necessary changes seem to be included. Will have a second look later today with some more time. But it is looking good.

al3mart
al3mart approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, no change requests from my side! Great job!

@chungquantin chungquantin merged commit 368d6d9 into main Jan 8, 2025
6 checks passed
@chungquantin chungquantin deleted the chungquantin/chore-stable2409 branch January 8, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

@al3mart al3mart al3mart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chungquantin @al3mart @AlexD10S