Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use floor() instead of round() in %% #365

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

UchidaMizuki
Copy link
Contributor

Fix #364.
I have enhanced tests for %% to make sure it behaves correctly.

Verified

This commit was signed with the committer’s verified signature.
vkubiv Volodymyr Kubiv
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f56521c) 91.54% compared to head (6ee538e) 91.58%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   91.54%   91.58%   +0.03%     
==========================================
  Files          19       19              
  Lines         994      998       +4     
==========================================
+ Hits          910      914       +4     
  Misses         84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Enchufa2
Copy link
Member

Good catch, thanks!

@Enchufa2 Enchufa2 merged commit 23751a7 into r-quantities:main Feb 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

%% doesn't work correctly due to rounding
2 participants