Use default pillar_shaft() method for numbers #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
reviewed
Mar 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 94.29% 94.40% +0.10%
==========================================
Files 18 18
Lines 877 876 -1
==========================================
Hits 827 827
+ Misses 50 49 -1
Continue to review full report at Codecov.
|
|
LGTM. Thanks! |
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives underlines for every other block of three digits, and all the other details of default pillar formatting.
Working on making formatting customizable, see https://pillar.r-lib.org/dev/articles/numbers.html for a primer. When merged, units will also benefit.
CC @lionel-.
Includes part of #274.