Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure correct ordering in set_units.mixed_units #272

Merged
merged 2 commits into from
Mar 10, 2021
Merged

ensure correct ordering in set_units.mixed_units #272

merged 2 commits into from
Mar 10, 2021

Conversation

Enchufa2
Copy link
Member

Fixes #271, and adds a test case to avoid future regressions.

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #272 (79ebaa1) into master (2512a42) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   94.14%   94.16%   +0.02%     
==========================================
  Files          18       18              
  Lines         871      874       +3     
==========================================
+ Hits          820      823       +3     
  Misses         51       51              
Impacted Files Coverage Δ
R/mixed.R 98.11% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2512a42...79ebaa1. Read the comment docs.

@Enchufa2 Enchufa2 merged commit d72c0e4 into master Mar 10, 2021
@Enchufa2 Enchufa2 deleted the fix/271 branch March 10, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The method set_units.mixed_units doesn't preserve a vector's ordering
1 participant