-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vctrs methods #247
Add vctrs methods #247
Conversation
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 94.11% 94.02% -0.09%
==========================================
Files 18 19 +1
Lines 900 920 +20
==========================================
+ Hits 847 865 +18
- Misses 53 55 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should have told you already: there's a feature/vctrs
branch also in this repo where I started to move things to R/tidyverse.R
, remove the old registration mechanism and put in place the new one. Could you please rebase this based on that one?
|
Currently there is rudimentary support via fallbacks. I think #248 first needs to be addressed to get robust tidyverse support for mixed units (with or without vctrs methods). |
Merged, thanks! |
Part of r-lib/vctrs#1130