Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vctrs methods #247

Merged
merged 5 commits into from
Jun 11, 2020
Merged

Add vctrs methods #247

merged 5 commits into from
Jun 11, 2020

Conversation

lionel-
Copy link
Contributor

@lionel- lionel- commented Jun 10, 2020

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #247 into master will decrease coverage by 0.08%.
The diff coverage is 86.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   94.11%   94.02%   -0.09%     
==========================================
  Files          18       19       +1     
  Lines         900      920      +20     
==========================================
+ Hits          847      865      +18     
- Misses         53       55       +2     
Impacted Files Coverage Δ
R/init.R 15.38% <0.00%> (-1.29%) ⬇️
R/misc.R 100.00% <ø> (+3.33%) ⬆️
R/mixed.R 100.00% <ø> (+2.08%) ⬆️
R/tidyverse.R 88.57% <88.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a0d88...ef30a0c. Read the comment docs.

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have told you already: there's a feature/vctrs branch also in this repo where I started to move things to R/tidyverse.R, remove the old registration mechanism and put in place the new one. Could you please rebase this based on that one?

NEWS.md Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
@Enchufa2
Copy link
Member

Enchufa2 commented Jun 10, 2020

mixed_units, being a list, don't require any special treatment from the {vctrs} point of view, right? (Apart from adding "list" to the class, which we did already).

@lionel-
Copy link
Contributor Author

lionel- commented Jun 11, 2020

Currently there is rudimentary support via fallbacks. I think #248 first needs to be addressed to get robust tidyverse support for mixed units (with or without vctrs methods).

@Enchufa2 Enchufa2 merged commit 9683538 into r-quantities:master Jun 11, 2020
@Enchufa2
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants