export classes and add docs #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I ended up doing this in a somewhat simpler fashion. I will release an updated version of xml2 next week with this fix included, and you can submit sos4R at that time. |
|
Oh, now I see you get a note if the classes are undocumented, so I will actually just use this PR afterall :) |
|
😃 I did the same thing: "Oh, that was quick to fix" and then |
|
@jimhester Do you plan a bugfix release for this? Otherwise I'll ask CRAN to admit sos4R despite the warning.. |
|
Yes, I will send a release early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #248
setOldClassseems to require some manual definitions in roxygen, I followed https://stackoverflow.com/questions/7758748/documenting-setas-and-setoldclass-with-roxygen#7766762