Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect_doppleganger throws warnings due to expect_snapshot_file deprecation of binary arg #110

Closed
arnaud-feldmann opened this issue Jun 17, 2021 · 1 comment

Comments

@arnaud-feldmann
Copy link

arnaud-feldmann commented Jun 17, 2021

Hi @lionel- ,

Hope you're doing well,

As it is stated in my title, expect_doppleganger throws a warning because of the deprecation of binary arg of testthat::expect_snapshot_file.

As you've done both commits, it is likely that you're aware of the issue. Through, in your master branch of vdiffr, it seems like the binary arg of testthat::expect_snapshot_file is still called.

image

Keep up the good work !

@lionel-
Copy link
Member

lionel- commented Jun 18, 2021

I forgot about that and the warning didn't surface in vdiffr tests :(

Thanks!

lionel- added a commit that referenced this issue Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants