-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks to style_pkg() #977
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if dd5e0ab is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Thanks Kirill. I think as we discussed in #965, changes in default arguments should probably not constitute a breaking change, in particular not excluding files, so I think we can release that with the next non-major release. If there are oblivious style issues that are easy to fix in the {cpp11} generated file, can we also fix the generation of that file easily? Also, for next time, can you add a news bullet in |
Would you be open to using fledge in this project? It's a lot better now, and we'll never need to think about manually adding stuff to The I came here because a change in default arguments broke my workflows 🙃 |
Codecov Report
@@ Coverage Diff @@
## main #977 +/- ##
=======================================
Coverage 90.12% 90.12%
=======================================
Files 47 47
Lines 2664 2664
=======================================
Hits 2401 2401
Misses 263 263
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if cf17b2e is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if f7c6189 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
R/cpp11.R
by default, even if it's harmlessFollow-up to #965.