Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect alignment for function declarations #968

Merged
merged 2 commits into from
Aug 6, 2022
Merged

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #959.

@lorenzwalthert lorenzwalthert changed the title detect alignemnt for function declarations detect alignment for function declarations Jul 26, 2022
@lorenzwalthert
Copy link
Collaborator Author

A pitty that touchstone run's are currently not sucessful, this might have speed implications... Let's wait.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

This is how benchmark results would change (along with a 95% confidence interval in relative change) if fe41786 is merged into main:

  • ❗🐌cache_applying: 27.9ms -> 33.2ms [+18.14%, +20.1%]
  •   :ballot_box_with_check:cache_recording: 1.38s -> 1.38s [-0.67%, +1.1%]
  •   :ballot_box_with_check:without_cache: 3.65s -> 3.65s [-0.52%, +0.41%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@codecov-commenter
Copy link

Codecov Report

Merging #968 (8a83039) into main (56d4a04) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #968      +/-   ##
==========================================
+ Coverage   89.89%   90.07%   +0.17%     
==========================================
  Files          47       47              
  Lines        2653     2660       +7     
==========================================
+ Hits         2385     2396      +11     
+ Misses        268      264       -4     
Impacted Files Coverage Δ
R/detect-alignment-utils.R 97.22% <100.00%> (+6.31%) ⬆️
R/detect-alignment.R 97.75% <100.00%> (+0.02%) ⬆️
R/rules-spaces.R 98.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 7e891fb is merged into main:

  • ❗🐌cache_applying: 26.3ms -> 30.2ms [+14.29%, +15.64%]
  •   :ballot_box_with_check:cache_recording: 1.28s -> 1.28s [-0.3%, +0.74%]
  •   :ballot_box_with_check:without_cache: 3.4s -> 3.4s [-0.66%, +0.55%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function signature
2 participants