Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~ should cause indention too #904

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #900.

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2022

Codecov Report

Merging #904 (731b2de) into main (1744cb3) will increase coverage by 0.72%.
The diff coverage is 97.56%.

❗ Current head 731b2de differs from pull request most recent head 67539e3. Consider uploading reports for the commit 67539e3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
+ Coverage   89.65%   90.38%   +0.72%     
==========================================
  Files          47       47              
  Lines        2514     2559      +45     
==========================================
+ Hits         2254     2313      +59     
+ Misses        260      246      -14     
Impacted Files Coverage Δ
R/rules-indention.R 100.00% <ø> (ø)
R/relevel.R 46.37% <60.00%> (+0.22%) ⬆️
R/communicate.R 92.30% <100.00%> (ø)
R/detect-alignment-utils.R 90.90% <100.00%> (+0.28%) ⬆️
R/detect-alignment.R 97.70% <100.00%> (+0.40%) ⬆️
R/roxygen-examples.R 98.43% <100.00%> (+0.05%) ⬆️
R/rules-line-breaks.R 100.00% <100.00%> (ø)
R/rules-tokens.R 100.00% <100.00%> (ø)
R/token-create.R 96.07% <100.00%> (+0.16%) ⬆️
R/transform-files.R 97.24% <100.00%> (+0.22%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38af4ad...67539e3. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 731b2de is merged into main:

  •   :ballot_box_with_check:cache_applying: 22.6ms -> 22.4ms [-2.68%, +0.84%]
  •   :ballot_box_with_check:cache_recording: 963ms -> 965ms [-1.37%, +1.72%]
  •   :ballot_box_with_check:without_cache: 2.62s -> 2.61s [-2.23%, +1.17%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit b70aebe into r-lib:main Mar 7, 2022
@lorenzwalthert lorenzwalthert deleted the issue-900 branch March 7, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacing of hanging formulas?
2 participants