Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect double indented function declarations with one line break only as double indented #1094

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #1092.

…ines, as the result depends on nest's newlines.
@codecov-commenter
Copy link

Codecov Report

Merging #1094 (3372f00) into main (8208348) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1094   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files          46       46           
  Lines        2711     2712    +1     
=======================================
+ Hits         2469     2470    +1     
  Misses        242      242           
Impacted Files Coverage Δ
R/rules-line-breaks.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8208348 is merged into main:

  •   :ballot_box_with_check:cache_applying: 48.5ms -> 48.5ms [-0.83%, +0.78%]
  •   :ballot_box_with_check:cache_recording: 779ms -> 778ms [-0.62%, +0.37%]
  •   :ballot_box_with_check:without_cache: 1.87s -> 1.87s [-0.24%, +0.43%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@IndrajeetPatil IndrajeetPatil merged commit e6fadbf into main Jan 30, 2023
@IndrajeetPatil IndrajeetPatil deleted the issue-1092 branch January 30, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New double-indented function style gets undone, causing lint
3 participants