-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if all examples run successfully #1068
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1068 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 46 46
Lines 2685 2685
=======================================
Hits 2445 2445
Misses 240 240
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure why not. Never heard of these additional checks. Is there documentation for those?
Yes, all additional checks can be found here. There is |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 55e8559 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Follow up on #1068, where I introduced these deviations.
\donttest
examples are run in an additional check by BDR, and probably\dontrun
examples are also run in some other checks.Therefore, making sure all examples run successfully (or are never run if they are just for illustrative purposes) is a good preventive practice in general.
This PR does that and also adds a workflow to catch such failures in the future.