Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guidelines #1047

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Update contributing guidelines #1047

merged 3 commits into from
Nov 7, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

There might be some whitespace changes, so you use the GitHub GUI feature to hide them and focus on the content-related changes.

@codecov-commenter
Copy link

Codecov Report

Merging #1047 (8e08f43) into main (4c1cb51) will not change coverage.
The diff coverage is n/a.

❗ Current head 8e08f43 differs from pull request most recent head 1f70d1f. Consider uploading reports for the commit 1f70d1f to get more accurate results

@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files          46       46           
  Lines        2687     2687           
=======================================
  Hits         2447     2447           
  Misses        240      240           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 742bc7b is merged into main:

  •   :ballot_box_with_check:cache_applying: 35.8ms -> 36ms [-1.54%, +3.17%]
  •   :ballot_box_with_check:cache_recording: 1.2s -> 1.19s [-1.68%, +0.16%]
  •   :ballot_box_with_check:without_cache: 3.01s -> 3s [-0.88%, +0.5%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks. We might want to also update some parts that are out of date like file structure or how to we use {fledge}, but we can merge these changes already.

@IndrajeetPatil IndrajeetPatil merged commit a995a35 into main Nov 7, 2022
@IndrajeetPatil IndrajeetPatil deleted the update_contributing branch November 7, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants