Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only link to R6 superclass if available #1393

Merged
merged 2 commits into from
Jul 10, 2022
Merged

Only link to R6 superclass if available #1393

merged 2 commits into from
Jul 10, 2022

Conversation

hadley
Copy link
Member

@hadley hadley commented Jul 10, 2022

Fixes #1236. Closes #1274.

This isn't perfect as you'll need to document twice if you document the class and superclass at the same time, but I think it's a decent improvement.

@hadley hadley requested a review from gaborcsardi July 10, 2022 21:05
Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@hadley hadley merged commit 8860c3c into main Jul 10, 2022
@hadley hadley deleted the super-link branch July 10, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R6 class inheriting from unexported parent causes check() error
2 participants