Inherit group params exactly #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
I don't understand all the technical bits, but it overall looks great! I ran this on iv too and it worked well DavisVaughan/ivs#12
R/rd-inherit.R
Outdated
| @@ -174,8 +176,12 @@ inherit_dot_params <- function(topic, topics, env) { | |||
| docs <- lapply(inheritors$source, find_params, topics = topics) | |||
| arg_matches <- function(args, docs) { | |||
| doc_args <- str_split(names(docs), ", ?") | |||
There was a problem hiding this comment.
Do you need doc_args anymore?
| #' B | ||
| #' | ||
| #' @inheritParams A | ||
| B <- function(x, y) {}" |
There was a problem hiding this comment.
Should you add a test where the args here are .x and .y to ensure that works? I tested it and it does work right, but a test may keep it from breaking in the future
yihui
added a commit
to rstudio/rmarkdown
that referenced
this pull request
Aug 16, 2022
…ent_base, otherwise the latter can't inherit it from the former because of the change in roxygen2 7.2.0: r-lib/roxygen2#1316
clrpackages
pushed a commit
to clearlinux-pkgs/R-rmarkdown
that referenced
this pull request
Aug 17, 2022
…n 2.15
Carson Sievert (1):
Fix html_document's client-side navbar updating in Bootstrap 5 (#2384)
Christophe Dervieux (2):
Add support for native math by default in Github document (#2362)
Test pandoc-devel on ubuntu latest (#2398)
Garrick Aden-Buie (1):
Use `while` instead of `for` loop when adjusting pandoc styles (#2380)
Maëlle Salmon (1):
Fix typo (#2392)
Michael Chirico (1):
fix typos (#2386)
Yihui Xie (4):
mark tufte_handout() as defunct
use tufte::tufte_handout in test, and remove tufte_handout in doc
moving the doc of extra_dependencies from html_document to html_document_base, otherwise the latter can't inherit it from the former because of the change in roxygen2 7.2.0: r-lib/roxygen2#1316
CRAN release v2.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #950
Example with ggplot2 at tidyverse/ggplot2#4791