Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal R6 links in LaTeX / PDF #1007

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Fix internal R6 links in LaTeX / PDF #1007

merged 1 commit into from
Mar 6, 2020

Conversation

gaborcsardi
Copy link
Member

Closes #1006.

hadley
hadley approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, although I didn't look at the rendered PDF to make sure it works.

@gaborcsardi gaborcsardi reopened this Dec 13, 2019
@gaborcsardi
Copy link
Member Author

(closed accidentally)

Seems reasonable, although I didn't look at the rendered PDF to make sure it works.

I did. :)

@gaborcsardi
Copy link
Member Author

There is a small risk that it will stop working, if base R switches to something else from hyperref, but it is pretty small, I would think.

@hadley
Copy link
Member

hadley commented Mar 5, 2020

Do you want to merge this?

@gaborcsardi gaborcsardi force-pushed the fix/r6-pdf-links branch 3 times, most recently from b461ba5 to 5696bc4 Compare March 6, 2020 10:38
@gaborcsardi
Copy link
Member Author

Yes, thanks, I added NEWS and will merge once the CI is done.

@gaborcsardi gaborcsardi merged commit 4fb892f into master Mar 6, 2020
@gaborcsardi gaborcsardi deleted the fix/r6-pdf-links branch March 6, 2020 11:52
@gaborcsardi
Copy link
Member Author

CI failure is unrelated.

@StrikerRUS StrikerRUS mentioned this pull request Mar 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'R CMD Rd2pdf <package>' produces a pdf-document but gives a lot of warnings.
2 participants
@gaborcsardi @hadley