We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E.g.
#' @export rbind.foobar <- function(..., deparse.level = 1) { print("hello") }
roxygen2 doesn't detect that rbind is an S3 generic, and so emits export(rbind.foobar) rather than S3method(rbind,foobar).
roxygen2
rbind
export(rbind.foobar)
S3method(rbind,foobar)
The text was updated successfully, but these errors were encountered:
This occurs because roxygen2:::is_s3_generic hides its S3 method check in is.primitive, but rbind is an internal function, not a primitive:
roxygen2:::is_s3_generic
is.primitive
https://github.com/klutometis/roxygen/blob/master/R/s3.R#L22-L26
I think that bit needs to accept both primitive functions and 'internal' functions (perhaps some special casing is needed for rbind, cbind?)
cbind
Sorry, something went wrong.
detect non-primitive known S3 generics (closes r-lib#488)
dad8ea6
485d78f
f07c4bf
7ac80d8
No branches or pull requests
E.g.
roxygen2
doesn't detect thatrbind
is an S3 generic, and so emitsexport(rbind.foobar)
rather thanS3method(rbind,foobar)
.The text was updated successfully, but these errors were encountered: