-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checking for missing S3 method exports hangs "forever" if you have large data objects in the package #1593
Comments
I'm running into this as well with https://github.com/alexpghayes/latentnetmediate and it's pretty debilitating. Downgrading to version 7.2.0 resolved my issue temporarily. Edit: #1594 also resolves my issue. Thanks! |
Hi, I wonder if noone with commit rights for roxygen is affected by this bug? What about @krlmlr or @DavisVaughan , could you maybe have a look? |
I was hoping this fix would make it into this latest release. To help demonstrate for any reviewers the problem, with my package which has a few moderately large example data sets but all with 7.3.2: > system.time({roxygen2::roxygenise()})
ℹ Loading TrialEmulation
user system elapsed
272.816 0.445 274.110 with the proposed fix in #1593 : > system.time({roxygen2::roxygenise()})
ℹ Loading TrialEmulation
user system elapsed
5.187 0.156 2.700 |
This is the last version not affected by a bug that makes the NAMESPACE generation hang virtually forever, as reported here: r-lib/roxygen2#1593
In package yet unpublished I have a large data object (the
.rda
file has about 6 MB). With current roxygen versions, the namespace roclet hangs herehttps://github.com/r-lib/roxygen2/blob/main/R/namespace.R#L402
This is apparently very inefficient if you have large objects in
s3objects
. If I remove the data object from the package, namespace generation proceeds swiftly as usual.The text was updated successfully, but these errors were encountered: