Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about methods for generics in suggested packages #1202

Closed
hadley opened this issue Feb 17, 2021 · 8 comments · Fixed by #1546
Closed

Think about methods for generics in suggested packages #1202

hadley opened this issue Feb 17, 2021 · 8 comments · Fixed by #1546
Labels
feature a feature request or enhancement rd ✍️
Milestone

Comments

@hadley
Copy link
Member

hadley commented Feb 17, 2021

e.g. https://dbplyr.tidyverse.org/reference/pivot_longer.tbl_lazy.html — the tidyr methods look different to the others because (as far as roxygen2 knows), they're not actually methods.

@hadley
Copy link
Member Author

hadley commented Apr 16, 2021

Need to standardise and/or document hack to load packages before roxygenise() is run: https://github.com/tidyverse/dtplyr/blob/master/DESCRIPTION#L42

@hadley hadley added feature a feature request or enhancement rd ✍️ labels Apr 16, 2021
@gaborcsardi
Copy link
Member

There is

Roxygen: list(packages = "foobar")

now. Isn't that good?

@hadley
Copy link
Member Author

hadley commented Apr 16, 2021

I know I tried that for dtplyr and I'm pretty sure it didn't work.

@gaborcsardi
Copy link
Member

Is that because you need to attach the package? I am fairly sure that the loading works.

@hadley
Copy link
Member Author

hadley commented Apr 16, 2021

Yeah, that's it.

@gaborcsardi
Copy link
Member

We can attach packages then maybe?

@hadley
Copy link
Member Author

hadley commented Apr 16, 2021

Yeah, that should be relatively harmless I'd think.

@hadley
Copy link
Member Author

hadley commented Apr 18, 2022

The original goal of the packages field was to load packages that provided other roclets, but it doesn't seem like attaching these packages will cause harm and creating another field seems like overkill.

@hadley hadley added this to the v7.2.4 milestone Nov 21, 2023
hadley added a commit that referenced this issue Nov 21, 2023
hadley added a commit that referenced this issue Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement rd ✍️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants