Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-licensing roxygen2 #1163

Closed
35 tasks done
hadley opened this issue Oct 30, 2020 · 48 comments · Fixed by #1172
Closed
35 tasks done

Re-licensing roxygen2 #1163

hadley opened this issue Oct 30, 2020 · 48 comments · Fixed by #1172

Comments

@hadley
Copy link
Member

hadley commented Oct 30, 2020

We are systematically re-licensing tidyverse and r-lib packages to use the MIT license, to make our package licenses as clear and permissive as possible. To do so, we need the approval of all copyright holders, which I have found by reviewing contributions from all all non-RStudio contributors. @briandk, @brodieG, @dougmitarotonda, @dpritchLibre, @egnha, @eibanez, @flying-sheep, @fmichonneau, @Geoff99, @gustavdelius, @halldc, @HenrikBengtsson, @jakob-r, @jameslamb, @jefferis, @jhchou, @jonthegeek, @JoshOBrien, @jranke, @klmr, @lindbrook, @LiNk-NY, @Lucaweihs, @maelle, @martin-mfg, @michaelquinn32, @mikefc, @mikemahoney218, @mikldk, @mikmart, @mjskay, @sgibb, @shrektan, @tobiaskley, @wibeasley, would you permit us to re-license roxygen2 with the MIT license? If so, please comment "I agree" below.

@gustavdelius
Copy link
Contributor

I agree

8 similar comments
@jranke
Copy link
Contributor

jranke commented Oct 30, 2020

I agree

@Lucaweihs
Copy link
Contributor

I agree

@mikemahoney218
Copy link
Contributor

I agree

@jonthegeek
Copy link
Contributor

I agree

@LiNk-NY
Copy link
Contributor

LiNk-NY commented Oct 30, 2020

I agree

@klmr
Copy link
Contributor

klmr commented Oct 30, 2020

I agree

@martin-mfg
Copy link
Contributor

I agree

@jefferis
Copy link
Contributor

I agree

@brodieG
Copy link
Contributor

brodieG commented Oct 30, 2020

As you well know by now I think it's a shame you're moving away from GPL.

Since my contributions are minimal I don't oppose the license change on the basis of my contributions (I agree).

One question though: on what basis do you believe that R being GPL doesn't require packages run on it to also be GPL? Is it because of the "interpreted code" FAQ "exemption". Or because you don't consider "R + package" to be the "modified work as a whole". I realize many folks believe that R's license doesn't apply to packages (including CRAN), but presumably you've had some extensive discussions on this before making these changes, so probably have specific reasons for believing so. Would you mind sharing those?

@jhchou
Copy link
Contributor

jhchou commented Oct 30, 2020

I agree

2 similar comments
@shrektan
Copy link
Contributor

I agree

@mjskay
Copy link
Contributor

mjskay commented Oct 30, 2020

I agree

@hadley
Copy link
Member Author

hadley commented Oct 30, 2020

@brodieG can you please keep the discussion on the ggplot2 issue?

@brodieG
Copy link
Contributor

brodieG commented Oct 30, 2020

Sure. For those interested it is this one:

tidyverse/ggplot2#4236

@brodieG
Copy link
Contributor

brodieG commented Oct 30, 2020

Just noticed @klutometis is not in the list and AFAICT he is not Rstudio (maybe he provided approval separately?)? Also, is it a given the Rstudio employees automatically consent to this type of license change, even if contributions precede employment, or is that done on a case by case basis? I think some contributions would fall in this category.

@batpigandme
Copy link
Contributor

@brodieG,
You're correct, this was discussed with Peter before we opened this issue. The same holds for RStudio contributions, and a handful of other contributors who've given us blanket permission across packages. Where there's someone at RStudio whose contributions precede their working at RStudio with whom we haven't discussed this, they've been included in our requests for permission.
Hope this helps.

@brodieG
Copy link
Contributor

brodieG commented Oct 30, 2020

Great, thanks @batpigandme, this does help. I didn't think Rstudio would be automatically taking copyright ownership of prior contributions (or requiring it as condition for employment), but it's nice to see it confirmed.

@tobiaskley
Copy link
Contributor

tobiaskley commented Oct 30, 2020 via email

@halldc
Copy link
Contributor

halldc commented Oct 30, 2020

I agree

1 similar comment
@briandk
Copy link
Contributor

briandk commented Oct 30, 2020

I agree

@JoshOBrien
Copy link
Contributor

JoshOBrien commented Oct 30, 2020 via email

@jameslamb
Copy link
Contributor

I agree

2 similar comments
@eibanez
Copy link
Contributor

eibanez commented Oct 30, 2020

I agree

@dpritchLibre
Copy link
Contributor

I agree

@lindbrook
Copy link
Contributor

I agree.

1 similar comment
@egnha
Copy link
Contributor

egnha commented Oct 30, 2020

I agree.

@mikldk
Copy link
Contributor

mikldk commented Oct 30, 2020

I agree

1 similar comment
@flying-sheep
Copy link
Contributor

I agree

@Geoff99
Copy link
Contributor

Geoff99 commented Oct 30, 2020

I agree

@michaelquinn32
Copy link
Contributor

michaelquinn32 commented Oct 30, 2020 via email

@klutometis
Copy link
Collaborator

I agree.

@sgibb
Copy link
Contributor

sgibb commented Oct 31, 2020

I agree

2 similar comments
@maelle
Copy link
Contributor

maelle commented Oct 31, 2020

I agree

@wibeasley
Copy link
Contributor

I agree

@dougmitarotonda
Copy link
Contributor

I agree.

2 similar comments
@mikmart
Copy link
Contributor

mikmart commented Nov 1, 2020

I agree.

@fmichonneau
Copy link
Contributor

I agree.

@jakob-r
Copy link
Contributor

jakob-r commented Nov 2, 2020

I agree

@batpigandme
Copy link
Contributor

Hi @HenrikBengtsson, @jefferis, @martin-mfg, and @mikefc,
We'd love to get your agreement please, if you could take a look when you have a chance. 🙂
Thanks!

@jefferis
Copy link
Contributor

I agree

(sorry @batpigandme, there were slew of similar requests at the same time and I thought I had responded to all of them)

@martin-mfg
Copy link
Contributor

I agreed: #1163 (comment)

@batpigandme
Copy link
Contributor

No need to apologize, @jefferis, I know all too well how easily notifications get lost on GH.

@batpigandme
Copy link
Contributor

Sorry, @martin-mfg, thanks for agreeing, and sorry for the re-ping!

@jefferis
Copy link
Contributor

No need to apologize, @jefferis, I know all too well how easily notifications get lost on GH.

Actually #1163 (comment) also, so I'm doubly agreed! ;-) All the best, Greg.

@HenrikBengtsson
Copy link
Contributor

I agree

@coolbutuseless
Copy link

I agree.

batpigandme added a commit that referenced this issue Nov 23, 2020
hadley pushed a commit that referenced this issue Nov 24, 2020
@Geoff99
Copy link
Contributor

Geoff99 commented Nov 24, 2020

Apologies, lost track of whether I've responded to this already or not, but just in case I haven't, I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.