Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix \figure output from markdown when the alternate text is empty #1051

Closed
gaborcsardi opened this issue Mar 6, 2020 · 0 comments · Fixed by #1054
Closed

Fix \figure output from markdown when the alternate text is empty #1051

gaborcsardi opened this issue Mar 6, 2020 · 0 comments · Fixed by #1054
Milestone
7.1.0

Comments

@gaborcsardi
Copy link
Member 

Reading 'man/markdown_pass1.Rd'
Error in if (substr(opt, 1, 9) == "options: ") { : 
  argument is of length zero
Calls: <Anonymous> ... flatten_para -> <Anonymous> -> .f -> as_html.tag_figure
In addition: Warning message:
In path[to_set] <- paste0(path_ext_remove(path[to_set]), ".", rep(ext,  :
  number of items to replace is not a multiple of replacement length
Execution halted
##[error]Process completed with exit code 1.

https://github.com/r-lib/roxygen2/runs/489923492
@gaborcsardi gaborcsardi added this to the 7.1.0 milestone Mar 6, 2020
@gaborcsardi gaborcsardi changed the title Fix pkgdown deployment Fix \figure output from markdown when the alternate text is empty Mar 6, 2020
gaborcsardi added a commit that referenced this issue Mar 6, 2020
@gaborcsardi
Fix \figure{} output from md when alternate text is empty
43649c0 
Then we need to leave out the second \figure{} argument,
according to WRE. This fixes pkgdown on roxygen2.

Closes #1051.
@gaborcsardi gaborcsardi mentioned this issue Mar 6, 2020
Merged
gaborcsardi added a commit that referenced this issue Mar 6, 2020
@gaborcsardi
Fix \figure{} output from md when alternate text is empty
01682a9 
Then we need to leave out the second \figure{} argument,
according to WRE. This fixes pkgdown on roxygen2.

Closes #1051.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

Fix \figure{} output from md when alternate text is empty r-lib/roxygen2
1 participant
@gaborcsardi