Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defuse numbered dots #1138

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Defuse numbered dots #1138

merged 3 commits into from
Mar 23, 2021

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented Mar 23, 2021

Closes #1137
Step towards tidyverse/dplyr#5815

enquo(..1) and enquos(...) with numbered dots supplied within ... now properly capture the underlying expressions and environments. This allows new metaprogramming patterns based on match.call(). For an example see tidyverse/dplyr@d4fd1e0f.

@lionel- lionel- requested a review from hadley March 23, 2021 16:32
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any particularly informed opinion on this, but it seems like a good idea.

@lionel- lionel- merged commit f289efb into master Mar 23, 2021
@lionel- lionel- deleted the defuse-numbered-dots branch March 23, 2021 17:02
@lionel- lionel- mentioned this pull request Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defusing numbered dots
2 participants