Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow explicit package names in Remotes #719

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

heavywatal
Copy link
Contributor

This package somehow manages differences in repo names vs package names. Ignoring the leading "pkgname=" part is enough to let this package work.

Addresses #676

This package somehow manages differences in repo names vs
package names. Ignoreing the leading "pkgname=" part is enough
to let this package work.

Addresses r-lib#676
@gaborcsardi
Copy link
Member

Great idea! I think we could make the implementation a bit safer by matching only something like ^[.a-zA-Z0-9]+= instead of just a plain = which might appear in some remote specifications.

@heavywatal
Copy link
Contributor Author

Revised. Thank you for the suggestion.

@gaborcsardi
Copy link
Member

Great, thanks! Can you please also add a bullet point to NEWS.md, mentioning this PR (or the issue) and your GH username?

@heavywatal
Copy link
Contributor Author

Done.

@gaborcsardi gaborcsardi merged commit bc0949d into r-lib:main Aug 30, 2022
@gaborcsardi
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants