Return dependencies in the reverse order #497
Merged
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimhester
force-pushed
the
reverse-dep-order
branch
from
e508edb to
a974857
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am hopeful this will be a robust fix for the errors when installing mixed source and binary packages, e.g. #301
Other previous fixes worked around part of the problem, but really the underlying issue is that
tools::package_dependencies(recursive = TRUE)just returns the unique dependencies in the order they are in the database. Because the dependencies in child nodes are always after their parents this means they are installed in the wrong order.In the cases where
install.packages()is installing only source packages or only binary packages there is no issue, asinstall.packages()handles the ordering internally for source packages, and the order you install binary packages doesn't matter.I believe returning the dependencies in the reverse order should ensure that child dependencies always come before their parents, which is the root cause of this issue.