Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #337 which currently prevents the installation of a package with dependencies hosted on a different service (e.g. a bitbucket package with github dependencies). It is effectively a revert of #145.
Important note: this will break the installation of private dependencies for people passing
auth_token
toinstall_github
and expecting it to be passed to the dependencies as well. Which is why I do not expect this PR to be merged (but see next steps below)Even if we just passed credentials (and not the host) to the dependencies, the install would still break when there is a collision in argument name. Typically, the wrong auth_token would be passed to the github dependency of a gitlab package.
There is however a very simple way to pass credentials to dependencies via environment variables.
Next steps: There is a more elaborate fix. Pass credentials (not host) to the dependency IF AND ONLY IF the dependency host matches the package host. This would not break existing installs so is really a better way to go.