teach remotes about the 'standard' remote type #310
Conversation
| @@ -166,6 +166,11 @@ package2remote <- function(name, lib = .libPaths(), repos = getOption("repos"), | |||
| } | |||
|
|
|||
| switch(x$RemoteType, | |||
| standard = remote("cran", | |||
There was a problem hiding this comment.
Well, I don't know if this would cause problems here, but "standard" just means that it was coming from a CRAN-like repo.
I think remotes will be fine with "cran", though....
There was a problem hiding this comment.
I figured this was the easiest way (at least for now) to have remotes just treat these standard remote types as CRAN-like, since cran remotes are already well-understood and handled elsewhere in the system. Do you think this should be handled differently?
At least, I believe this works as a stop-gap solution.
There was a problem hiding this comment.
I think it will be fine. I think for remotes "cran" means "cran-like", mostly.
There was a problem hiding this comment.
@jimhester do you think this would fail in any way?
There was a problem hiding this comment.
Yeah I think this would be fine.
Closes #309.