Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore newline after Additional_repositories (fix #251) #299

Merged
merged 7 commits into from
Apr 10, 2019
Merged

Ignore newline after Additional_repositories (fix #251) #299

merged 7 commits into from
Apr 10, 2019

Conversation

tmelliott
Copy link
Contributor

New lines after Additional_repositories was resulting in a repository of "":

Additional_repositories:
    https://some.other.repo

parsed as

remotes::parse_additional_repositories(pkg)
# c("", "https://some.other.repo")

@jimhester jimhester merged commit 91c64b3 into r-lib:master Apr 10, 2019
@jimhester
Copy link
Member

Looks good, thanks for the PR and for writing a test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmelliott @jimhester