Custom headers in HTTP, use headers for basic auth #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jimhester I still need to update the NEWS, and add some more docs, but otherwise I think this is good. |
BitBucket does not support Basic Auth via URL encoding, apparently. So we use HTTP headers instead. This is somewhat tricky, because base R download.file()) does not allow that directly. We need to shadow an internal function in utils, and also make use of a bugs in curl and the internal download methods, that let you specify multiple HTTP headers via the User-Agent option. This will also fix #255.
It does not support HTTPS.
The default download method now respects the `download.file.method` user option, if set. Otherwise, if libcurl is supported, it will be selected. (Before, wininet was preferred on Windows, because it sets the proxies automatically, see #46.)
gaborcsardi
force-pushed
the
fix/http-headers-auth
branch
from
38b7259 to
c4626ec
Compare
|
OK, added NEWS and docs. |
|
It looks fine, thanks! HTTP in base R is quite a mess |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BitBucket does not support Basic Auth via URL encoding,
apparently. So we use HTTP headers instead. This is somewhat
tricky, because base R download.file()) does not allow
that directly. We need to shadow an internal function in utils,
and also make use of some bugs in curl and the internal
download methods, that let you specify multiple HTTP headers
via the User-Agent option.
This will also fix #255.
This PR also changes the default download method, slightly.
The default download method now respects the
download.file.methoduser option, if set.Otherwise, if libcurl is supported, it will be
selected. (Before, wininet was preferred on Windows,
because it sets the proxies automatically, see #46.)