Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitbucket_remote should have a default host #342

Closed
antoine-sachet opened this issue Apr 10, 2019 · 0 comments
Closed

bitbucket_remote should have a default host #342

antoine-sachet opened this issue Apr 10, 2019 · 0 comments

Comments

@antoine-sachet
Copy link
Contributor

Just like github_remote and gitlab_remote, bitbucket_remote should specify the default host.
Otherwise, remote bitbucket dependencies cannot be installed even if #337 is fixed.

The fix is in install-bitbucket.R, changing this:

bitbucket_remote <- function(repo, ref = "master", subdir = NULL,
                              auth_user = NULL, password = NULL, sha = NULL,
                              host = NULL, ...) { .. }

to this:

bitbucket_remote <- function(repo, ref = "master", subdir = NULL,
                              auth_user = NULL, password = NULL, sha = NULL,
                              host = "api.bitbucket.org/2.0", ...) { .. }
antoine-sachet added a commit to antoine-sachet/remotes that referenced this issue Apr 10, 2019

Verified

This commit was signed with the committer’s verified signature.
jbudz Jon
antoine-sachet added a commit to antoine-sachet/remotes that referenced this issue Apr 10, 2019
jimhester pushed a commit that referenced this issue Apr 10, 2019
Bitbucket uses host rather than sha as the key name.

Fixes #342 
Fixes #343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant