Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse S3 methods with non-syntactic names #2385

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

hadley
Copy link
Member

@hadley hadley commented Dec 12, 2023

\method{}, unlike \S4method{}, requires non-syntactic names to be escaped with backticks, so we don't need to escape again.

Fixes #2384

`\method{}`, unlike `\S4method{}`, requires non-syntactic names to be escaped with backticks, so we don't need to escape again.

Fixes #2384
@hadley hadley requested a review from krlmlr December 12, 2023 13:04
Copy link
Member

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for tibble, thanks!

@hadley hadley merged commit 548a949 into main Jan 3, 2024
13 checks passed
@hadley hadley deleted the s3-non-syntactic-usage branch January 3, 2024 00:34
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this pull request Jun 1, 2024
`\method{}`, unlike `\S4method{}`, requires non-syntactic names to be escaped with backticks, so we don't need to escape again.

Fixes r-lib#2384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tibble fails to parse usage
2 participants