Implement sticky navbar in css #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works for me on Chrome. Can you check a few other browsers? |
|
I worked with Firefox. I can tests on other browsers tomorrow. Feel free to ping me again if I forget again and nothing happens in the next couple of days. Note to self: looks like the |
|
Tested on Firefox, Chromium and midori (based on an old webkit version). It looks fine. |
|
Tested on latest safari version as well (12.1) and it works fine with the |
|
In general I am in favor of relying less on external libraries for the site. Looks fine to me. |
hadley
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Scroll-linked_effects
Not entirely sure I did everything right so feel free to test more before merging (I will do the same on my end).