Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused fonts are bundled / distributed after bslib update #2393

Closed
srfall opened this issue Jan 28, 2024 · 0 comments · Fixed by #2395
Closed

Unused fonts are bundled / distributed after bslib update #2393

srfall opened this issue Jan 28, 2024 · 0 comments · Fixed by #2395

Comments

@srfall
Copy link

srfall commented Jan 28, 2024

I updated bslib from version 0.5.1 to 0.6.1.9001 and now my pkgdown site contains 70 compressed fonts in deps/bootstrap-5.3.1 while the previous bootstrap-5.2.2 directory contained no font at all.

I'm relatively certain that my site dosn't use 70 different fonts. Is that the expected/ desired behavior?

R version 4.3.2 (2023-10-31 ucrt)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 11 x64 (build 22631)
....
loaded via a namespace (and not attached):
 [1] vctrs_0.6.4     cli_3.6.2       knitr_1.45      rlang_1.1.3
 [5] xfun_0.41       processx_3.8.2  purrr_1.0.1     jsonlite_1.8.8
 [9] glue_1.7.0      rprojroot_2.0.3 htmltools_0.5.7 ps_1.7.5
[13] fansi_1.0.4     rmarkdown_2.25  evaluate_0.23   tibble_3.2.1
[17] fastmap_1.1.1   yaml_2.3.7      lifecycle_1.0.4 memoise_2.0.1
[21] compiler_4.3.2  fs_1.6.3        pkgconfig_2.0.3 digest_0.6.34
[25] R6_2.5.1        utf8_1.2.3      pillar_1.9.0    callr_3.7.3    
[29] magrittr_2.0.3  tools_4.3.2     withr_2.5.0     pkgdown_2.0.7
[33] cachem_1.0.8    desc_1.4.2
hadley pushed a commit that referenced this issue Apr 8, 2024
Including improved error messages and pass through to `bslib::bs_theme()`.

Fixes #2393. Fixes #2376.
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this issue Jun 1, 2024
Including improved error messages and pass through to `bslib::bs_theme()`.

Fixes r-lib#2393. Fixes r-lib#2376.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant