Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rtools_needed always returning custom #98

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

burgerga
Copy link
Contributor

@burgerga burgerga commented Jun 12, 2020

Because the 'custom' entry in version_info has quite a large range and is checked first, rtools_needed always returned 'custom'. (as discussed in #97)

This fix:

  • copies version_info to a local variable and removes custom
  • sets r_version as function argument so the function can be unit tested
  • adds unit tests for some frozen/bogus versions of R

All checks pass!

@jimhester
Copy link
Member

Thanks! Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@burgerga
Copy link
Contributor Author

burgerga commented Jul 8, 2020

Done! (and rebased)

@jimhester
Copy link
Member

Thanks!

Thank you!

@jimhester jimhester merged commit 81ab98a into r-lib:master Jul 8, 2020
@burgerga burgerga deleted the fix_rtools_needed branch July 8, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants