Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -std=gnu99 to CFLAGS on Windows #46

Closed

Conversation

yutannihilation
Copy link

I found AppVeyor keeps failing on tibble repo and it seems this is because of the absense of -std=gnu99: tidyverse/tibble#485

pkgbuild defines CFLAGS by itself, but Windows seems to need -std=gnu99 as the default is so.

PS C:\...> R.exe CMD config CFLAGS
-O2 -Wall -std=gnu99 -mtune=generic

PS C:\...> R.exe CMD config CXXFLAGS
-O2 -Wall -mtune=generic

PS C:\...> R.exe CMD config CXX11FLAGS
-O2 -Wall -mtune=generic

@jimhester jimhester closed this in d7c21b1 Sep 19, 2018
@jimhester
Copy link
Member

Thanks for the PR! I decided to fix this in a different way instead.

@yutannihilation
Copy link
Author

Oh, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants