fix and test namespace_imports() in object_name_linter #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #642 also increases coverage of R/namespace.R to 100%
Merged
| linted_files <- unique(names(lints)) | ||
|
|
||
| # lintr paths contain backslash on windows, list.files uses forward slash. | ||
| linted_files <- gsub("\\", "/", linted_files, fixed = TRUE) |
There was a problem hiding this comment.
not particularly important for a test case like this but i think normalizePath handles this right?
There was a problem hiding this comment.
We'd have to normalize both paths because that also makes them absolute.
MichaelChirico
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #642
also increases coverage of R/namespace.R to 100%