Skip to content

Conversation

MichaelChirico
Copy link
Collaborator

Part of #584

I applied several linters across R/ here:

  • commas_linter
  • trailing_blank_lines_linter
  • spaces_left_parentheses_linter
  • object_usage_linter
  • function_left_parentheses_linter
  • paren_brace_linter

I skipped equals_na_linter which only gives a spurious match that would be fixed by #546. Similarly there's a spurious instance of paren_brace_linter that applies to it's own source where "){" is present. We should move that linter to match on the parse tree as well.

@russHyde
Copy link
Collaborator

Hi. I moved paren_brace_linter over to the parse tree in #441 (which is now pretty out of date)

@AshesITR AshesITR merged commit 41d0471 into master Nov 27, 2020
@AshesITR AshesITR deleted the lint-lintr branch November 27, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants