apply some linters to R/ #591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #584
I applied several linters across R/ here:
commas_linter
trailing_blank_lines_linter
spaces_left_parentheses_linter
object_usage_linter
function_left_parentheses_linter
paren_brace_linter
I skipped
equals_na_linter
which only gives a spurious match that would be fixed by #546. Similarly there's a spurious instance ofparen_brace_linter
that applies to it's own source where"){"
is present. We should move that linter to match on the parse tree as well.