Catch extraneous ... arguments to lint()/lint_dir() early #2147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
force-pushed
the
mv-lint
branch
from
298b300 to
b4c1636
Compare
Codecov Report
@@ Coverage Diff @@
## main #2147 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 112 112
Lines 5110 5120 +10
=======================================
+ Hits 5092 5102 +10
Misses 18 18
|
AshesITR
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2134 .
This convinced me more about vectorizing
lint()for #2135 and handling more argument checking directly there -- that would avoid the need to duplicate callscheck_dots()(in this PR, it's called once inlint_dir()and then many times, once for each input file).NB: diffbased against #2146